Remove box-shadow as well as outline
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Phil - I was hoping to add this in v2, but haven't quite got that ready for release yet. I'll see if I can get this working in v1 behind a feature flag or something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lindsayevans , here's a quick PR to reset the
box-shadowas well asoutline.This is useful for users who use
box-shadowto apply a focus ring instead of outline, Bootstrap 4 does this for example, and it's useful if you want a focus ring to follow theborder-radiusof the focusable element.However, this might cause unintended consequences for some people who have box-shadows on elements such as buttons, so I'll understand completely if you chose not to reset this property for that reason.
For users who want this behaviour, you can load my fork from JSDelivr:
https://cdn.jsdelivr.net/gh/philwolstenholme/outline.js@master/outline.min.js